-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Refactor GrpcHandler to not use CDI and be more a utility #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've refactored the GrpcHandler class to remove its direct dependency on CDI (Contexts and Dependency Injection), making it a more flexible and reusable utility. This change promotes a cleaner separation of concerns by moving dependency provision to concrete subclasses, as demonstrated by the updated QuarkusGrpcHandler.
Highlights
- Decoupling GrpcHandler from CDI: The GrpcHandler class is now an abstract class, shedding its @ApplicationScoped annotation and direct @Inject fields, promoting a more decoupled design.
- Dependency Provision via Abstract Methods: Dependencies like AgentCard, RequestHandler, and CallContextFactory are now accessed via new protected abstract getter methods within GrpcHandler, allowing subclasses to provide them.
- Quarkus-specific Implementation: QuarkusGrpcHandler has been updated to inject these dependencies in its constructor and provide them through the overridden abstract methods, serving as a concrete implementation for the abstract GrpcHandler.
- Test Class Updates: Test classes, specifically GrpcHandlerTest, now utilize a new TestGrpcHandler subclass to properly instantiate and test the refactored GrpcHandler, ensuring testability of the new design.
- Configurable Test Port: The AgentCardProducer in test utilities now supports configuring the agent card's URL port via a system property, enhancing test environment flexibility.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully refactors GrpcHandler to remove its dependency on CDI, making it an abstract utility class. This is a solid architectural improvement that increases modularity and testability. The changes are consistently applied, with a new QuarkusGrpcHandler for the CDI-based environment and an inner TestGrpcHandler for unit testing. My feedback includes a few minor suggestions to further improve code quality.
reference/grpc/src/main/java/io/a2a/server/grpc/quarkus/QuarkusGrpcHandler.java
Outdated
Show resolved
Hide resolved
transport/grpc/src/test/java/io/a2a/grpc/handler/GrpcHandlerTest.java
Outdated
Show resolved
Hide resolved
transport/grpc/src/test/java/io/a2a/grpc/handler/GrpcHandlerTest.java
Outdated
Show resolved
Hide resolved
transport/grpc/src/test/java/io/a2a/grpc/handler/GrpcHandlerTest.java
Outdated
Show resolved
Hide resolved
transport/grpc/src/test/java/io/a2a/grpc/handler/GrpcHandlerTest.java
Outdated
Show resolved
Hide resolved
transport/grpc/src/test/java/io/a2a/grpc/handler/GrpcHandlerTest.java
Outdated
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors GrpcHandler to be an abstract class, removing its direct dependency on CDI. This is a good architectural improvement, making the handler more of a reusable utility. The dependencies are now supplied by concrete subclasses through abstract methods, as demonstrated by the new QuarkusGrpcHandler for CDI environments and a TestGrpcHandler for tests. The changes are well-executed. I have a few minor suggestions to improve code consistency.
No description provided.